Repository navigation
refactor(engine): the effect scan resolves its options before scanning - #7336
Merged
Merged
Conversation
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved at 66145876. I found no behavior change.
- The defaults (
budgetMs,now,onProgress) still apply only when a value isundefined. Moving them into the outer signature does not change when they take effect.onProgress = () => {}makes the unconditional call in the loop equal to the oldonProgress?.(). onEndis now read once when the call starts, where before it was read infinally. The only production caller (frameCapture.ts:1362) passes a fresh object literal, so the two behave the same.- Locally at this head:
riskFrames.test.ts19/19 passed andtsc --noEmitinpackages/engineis clean. The branch contains currentmain. - This is a refactor, not a fix, so no fails-without-the-fix line is needed.
Contributor
Edit accuracy: accurate 267 (base branch 267), smooth 91 of thoseThe gate passes. Quarantined, measured but not gated (8)
Unstable (1)
|
miguel-heygen
enabled auto-merge
November 6, 2026 21:16
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 7, 2026
…-com#7336-heygen-com#7358 Adopt heygen-com#7304 (without CLI renderDiagnostic, needs heygen-com#6725), heygen-com#7331, heygen-com#7332, heygen-com#7334, heygen-com#7337, heygen-com#7336, heygen-com#7339, heygen-com#7289, heygen-com#5594, heygen-com#6900, heygen-com#7322, heygen-com#7342, heygen-com#7343, heygen-com#7350 (onProgress only), heygen-com#7352, heygen-com#7348, heygen-com#7344, heygen-com#7353, heygen-com#7356 and heygen-com#7355. Defer heygen-com#5708 (needs heygen-com#6911) and heygen-com#7345 (READ_VERSION 4 vs 7); heygen-com#7307 not applicable. Re-read 14 moved pins, pin 6 new PRs (monitored 126). Make checkReportFile module-private and suppress the cross-package closeTestChrome duplicate for fallow. Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com> Co-authored-by: SophiaHuangCc <129631224+SophiaHuangCc@users.noreply.github.com> Co-authored-by: Dante <duanjl.china@gmail.com> Co-authored-by: Muzzy5150 <muzzy5150yt@gmail.com> Co-authored-by: ump45nose <52391318+ump45nose@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The effect scan's loop no longer resolves its option defaults, which brings it back under the complexity limit. No behavior changes.
Why
#7331 split
scanCssEffectLiveFramesso that its new end signal fires on every exit, and the inner loop came out at a CRAP score of 31.6 against a limit of 30. #7331 was already in the merge queue when the audit reported, so this follows it.Related work
Follows #7331.
How
scanCssEffectLiveFramesresolvesbudgetMs,nowandonProgressonce and passes them to the loop. The loop no longer reads an options object, and it callsonProgresswithout the optional check.Test plan
riskFrames.test.ts, 19 passed, on the same code before it was rebased onto main.tsc --noEmitinpackages/engineis clean.bunx fallow audit --base origin/main: verdict pass, 0 complexity findings.Size
12 added lines and 5 removed in one file. It stands alone because #7331 had already merged.